Support NetBSD 10+ version of struct statvfs#4277
Closed
0-wiz-0 wants to merge 0 commit intorust-lang:mainfrom
0-wiz-0:master
Closed
Support NetBSD 10+ version of struct statvfs#42770-wiz-0 wants to merge 0 commit intorust-lang:mainfrom 0-wiz-0:master
0-wiz-0 wants to merge 0 commit intorust-lang:mainfrom
0-wiz-0:master
Conversation
Collaborator
0-wiz-0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #4265 (comment) it was suggested to update the NetBSD
struct statvfscode for changes in NetBSD 10.See https://mail-index.netbsd.org/source-changes/2019/09/22/msg109266.html
I tested this code on NetBSD 10.99.12/x86_64 with bespoke test programs for
fstatvfs,getmntinfo,getvfsstat, andstatvfs.This code is not ready to merge yet, since it doesn't work on NetBSD 9, and I need some guidance on how to handle this.
Should we add versioning support like
freebsd12etc. or is some other method preferred?